gerrit: Update documentation - #10074
Queued
josephlou5 wants to merge 2 commits into
Queued
Conversation
josephlou5
commented
Aug 28, 2026
josephlou5
force-pushed
the
josephlou5-rwukonnmrrrm
branch
from
August 29, 2026 02:03
82aba1a to
3b3a563
Compare
yuja
approved these changes
Aug 29, 2026
josephlou5
force-pushed
the
josephlou5-rwukonnmrrrm
branch
2 times, most recently
from
August 29, 2026 02:54
0f9b761 to
71032d9
Compare
Contributor
Author
|
I'll give it a day or two in case @matts1 has any objections or thoughts. |
matts1
approved these changes
Aug 31, 2026
matts1
left a comment
matts1
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but some minor nits
josephlou5
force-pushed
the
josephlou5-rwukonnmrrrm
branch
2 times, most recently
from
August 31, 2026 01:48
7b3d406 to
171bb38
Compare
- Made all references to Gerrit's "change ID" concept consistently say `Change-Id`, and all Jujutsu's "change ID" concept say "change ID" (the latter was only updated in Gerrit-related documentation; I didn't look everywhere). - Changed "footer" to "trailer" everywhere. - Made "patch set" two words everywhere (Google says two words is more correct, I guess). - Added a "Gerrit" section in `docs/config.md`, which is a more concise list of the options explained in `docs/gerrit.md`.
`Change-Id` or `Link` values added during `jj gerrit upload` (i.e., when the commit didn't have either of these trailers before) may cause divergence when fetching from the remote after a change is merged: same jj change ID, but different commit ID due to the different descriptions.
josephlou5
force-pushed
the
josephlou5-rwukonnmrrrm
branch
from
August 31, 2026 17:20
171bb38 to
fc57b79
Compare
josephlou5
added this pull request to the merge queue
Aug 31, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.